Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server_configurations.md #3307

Closed
wants to merge 1 commit into from
Closed

Update server_configurations.md #3307

wants to merge 1 commit into from

Conversation

tskj
Copy link

@tskj tskj commented Sep 17, 2024

Note depreaction / rename in docs.

Should also arguably have a history of deprecations somewhere!

Note depreaction / rename in docs.
@tskj tskj requested a review from glepnir as a code owner September 17, 2024 08:30
Copy link
Contributor

Note that server_configurations.md or server_configurations.txt will be regenerated by the docgen CI process. Edit the Lua source file instead. For details on generating documentation, see: https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#generating-docs

@glepnir
Copy link
Member

glepnir commented Sep 17, 2024

this is also not very useful . it's better show deprecate server in lspinfo command this will very useful.

@tskj
Copy link
Author

tskj commented Sep 17, 2024

I disagree. Yes, it's helpful to show the message where you put it and I don't suggest you remove it, but I strongly disagree that putting it in the documentation like I have suggested here isn't also extremely useful.

It's very confusing for a user like me to come back to your documentation after many months and not find tsserver which I very vividly remember being here! And no explanation or note whatsoever about what happened to it. Remember, not every user knows everything you know about the project. Explicitness and clarity is useful and good.

@glepnir
Copy link
Member

glepnir commented Sep 17, 2024

I mean update the lspinfo and deprecate message . doc is genereate from bot . update there does not make sense wait for a while

@tskj
Copy link
Author

tskj commented Sep 17, 2024

I am not entirely sure I understand what you mean by this, although I seem to gather that the file I changed is autogenerated? It would probably be best if you updated the correct place then, I'm not sure where that would be.

@glepnir
Copy link
Member

glepnir commented Sep 19, 2024

the document is generate from source lua file so edit it directly not a good idea now you can get the deprecate list in lspinfo instead search doc..

@glepnir glepnir closed this Sep 19, 2024
@justinmk
Copy link
Member

now you can get the deprecate list in lspinfo

See #3308 for an example of LspInfo showing the "deprecated servers" message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants